Skip to content

feat: added disabled prop to checkbox and cleaned code #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

feat: added disabled prop to checkbox and cleaned code #4958

merged 2 commits into from
May 18, 2025

Conversation

@bjoaquinc
Copy link
Contributor

@bjoaquinc bjoaquinc commented May 16, 2025 •
edited
Loading

📝 Summary

Added disabled to checkbox

Screenshot 2025-05-16 at 3 58 31 PM

🔍 Description of Changes

  • Added disabled to CheckboxPlugin.tsx and made the code more DRY by matching the pattern of Data and T found in other files like SliderPlugin.tsx
  • Mapped the checkbox class in input.py to the disabled property with definition

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@mscolnick

@vercel
Copy link

vercel bot commented May 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 8:07pm

mscolnick
mscolnick approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mscolnick mscolnick merged commit 8ba689d into marimo-team:main May 18, 2025
23 of 33 checks passed
@github-actions
Copy link

github-actions bot commented May 18, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.11-dev6

@bjoaquinc bjoaquinc deleted the add-disabled-checkbox branch May 18, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjoaquinc @mscolnick